]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
octeon_ep: Fix host hang issue during device reboot
authorSathesh B Edara <sedara@marvell.com>
Tue, 29 Apr 2025 11:46:24 +0000 (04:46 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 9 May 2025 07:44:02 +0000 (09:44 +0200)
commit7e1ca1bed3f66e00377f7d2147be390144924276
tree5cb9ac0127c7dae7d14c524af229601db3e83b85
parent0e32cbcbc4cb415e6d3967205c9ee88dc8454b63
octeon_ep: Fix host hang issue during device reboot

[ Upstream commit 34f42736b325287a7b2ce37e415838f539767bda ]

When the host loses heartbeat messages from the device,
the driver calls the device-specific ndo_stop function,
which frees the resources. If the driver is unloaded in
this scenario, it calls ndo_stop again, attempting to free
resources that have already been freed, leading to a host
hang issue. To resolve this, dev_close should be called
instead of the device-specific stop function.dev_close
internally calls ndo_stop to stop the network interface
and performs additional cleanup tasks. During the driver
unload process, if the device is already down, ndo_stop
is not called.

Fixes: 5cb96c29aa0e ("octeon_ep: add heartbeat monitor")
Signed-off-by: Sathesh B Edara <sedara@marvell.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250429114624.19104-1-sedara@marvell.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/marvell/octeon_ep/octep_main.c