]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/amd/amdgpu: Fix SMU warning during isp suspend-resume
authorPratap Nirujogi <pratap.nirujogi@amd.com>
Wed, 10 Dec 2025 01:22:15 +0000 (20:22 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 5 Jan 2026 22:29:51 +0000 (17:29 -0500)
commit7ed51e3a1381422278933d0d3ebda0268b6825de
tree016503dd35bc24beed74de9943ed959479c604a1
parent531b43260928a53f4190f3e61de788551af6157e
drm/amd/amdgpu: Fix SMU warning during isp suspend-resume

ISP mfd child devices are using genpd and the system suspend-resume
operations between genpd and amdgpu parent device which uses only
runtime suspend-resume are not in sync.

Linux power manager during suspend-resume resuming the genpd devices
earlier than the amdgpu parent device. This is resulting in the below
warning as SMU is in suspended state when genpd attempts to resume ISP.

WARNING: CPU: 13 PID: 5435 at drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:398 smu_dpm_set_power_gate+0x36f/0x380 [amdgpu]

To fix this warning isp suspend-resume is handled as part of amdgpu
parent device suspend-resume instead of genpd sequence. Each ISP MFD
child device is marked as dev_pm_syscore_device to skip genpd
suspend-resume and use pm_runtime_force api's to suspend-resume
the devices when callbacks from amdgpu are received.

Co-developed-by: Gjorgji Rosikopulos <grosikop@amd.com>
Signed-off-by: Gjorgji Rosikopulos <grosikop@amd.com>
Signed-off-by: Bin Du <bin.du@amd.com>
Signed-off-by: Pratap Nirujogi <pratap.nirujogi@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 0288a345f19b2162546352161509bb24614729e1)
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.h
drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c