]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
fwctl/mlx5: Fix memory alloc/free in mlx5ctl_fw_rpc()
authorAkhilesh Patil <akhilesh@ee.iitb.ac.in>
Sat, 16 Aug 2025 06:19:54 +0000 (11:49 +0530)
committerJason Gunthorpe <jgg@nvidia.com>
Mon, 18 Aug 2025 23:52:17 +0000 (20:52 -0300)
commit7f059e47326746ceebe2a984bd6124459df3b458
tree89c06001432fa773050820652cb5146007345b12
parentc17b750b3ad9f45f2b6f7e6f7f4679844244f0b9
fwctl/mlx5: Fix memory alloc/free in mlx5ctl_fw_rpc()

Use kvfree() to free memory allocated by kvzalloc() instead of kfree().
Avoid potential memory management issue considering kvzalloc() can
internally choose to use either kmalloc() or vmalloc() based on memory
request and current system memory state. Hence, use more appropriate
kvfree() which automatically determines correct free method to avoid
potential hard to debug memory issues.  Fix this issue discovered by
running spatch static analysis tool using coccinelle script -
scripts/coccinelle/api/kfree_mismatch.cocci

Fixes: 52929c2142041 ("fwctl/mlx5: Support for communicating with mlx5 fw")
Link: https://patch.msgid.link/r/aKAjCoF9cT3VEbSE@bhairav-test.ee.iitb.ac.in
Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/fwctl/mlx5/main.c