]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net_sched: remove a redundant goto chain check
authorCong Wang <xiyou.wangcong@gmail.com>
Mon, 28 Sep 2020 18:31:03 +0000 (11:31 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 09:07:02 +0000 (10:07 +0100)
commit7f1b0fa4805cf360d250316ca26e4ccac27b11c7
tree8249e1aec10ca362b772a1c8cdd2c1836f5c3a62
parentf736e9e2f7502775c1fc03d22107a65adf0edc90
net_sched: remove a redundant goto chain check

[ Upstream commit 1aad8049909a6d3379175ef2824a68ac35c0b564 ]

All TC actions call tcf_action_check_ctrlact() to validate
goto chain, so this check in tcf_action_init_1() is actually
redundant. Remove it to save troubles of leaking memory.

Fixes: e49d8c22f126 ("net_sched: defer tcf_idr_insert() in tcf_action_init_1()")
Reported-by: Vlad Buslov <vladbu@mellanox.com>
Suggested-by: Davide Caratti <dcaratti@redhat.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sched/act_api.c