]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
[IPV4]: Do not disable preemption in trie_leaf_remove().
authorRobert Olsson <robert.olsson@its.uu.se>
Tue, 20 Mar 2007 22:21:39 +0000 (23:21 +0100)
committerAdrian Bunk <bunk@stusta.de>
Tue, 20 Mar 2007 22:21:39 +0000 (23:21 +0100)
commit7f1b44d7f0758a6e46280969880435c91b60b5cc
treecb65b627eb20d3d01f1de4bb90fd775df56c81d8
parentcf2c008865ae7d62d28e3d63f14935f19a4cb6f5
[IPV4]: Do not disable preemption in trie_leaf_remove().

Hello, Just discussed this Patrick...

We have two users of trie_leaf_remove, fn_trie_flush and fn_trie_delete
both are holding RTNL. So there shouldn't be need for this preempt stuff.
This is assumed to a leftover from an older RCU-take.

> Mhh .. I think I just remembered something - me incorrectly suggesting
> to add it there while we were talking about this at OLS :) IIRC the
> idea was to make sure tnode_free (which at that time didn't use
> call_rcu) wouldn't free memory while still in use in a rcu read-side
> critical section. It should have been synchronize_rcu of course,
> but with tnode_free using call_rcu it seems to be completely
> unnecessary. So I guess we can simply remove it.

Signed-off-by: Robert Olsson <robert.olsson@its.uu.se>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
net/ipv4/fib_trie.c