]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
vhost: Check docket sk_family instead of call getname
authorEugenio Pérez <eperezma@redhat.com>
Thu, 5 Mar 2020 16:30:05 +0000 (17:30 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 11 Mar 2020 06:53:08 +0000 (07:53 +0100)
commit7f574e92e4474f1b33425c4ee9ba48cd4fbe7d75
tree16dabd193f056155ffd6e8e331ab409ea9e4738f
parenteef128dd4dcdb96b3ca0ae64ad9f752008066844
vhost: Check docket sk_family instead of call getname

[ Upstream commit 42d84c8490f9f0931786f1623191fcab397c3d64 ]

Doing so, we save one call to get data we already have in the struct.

Also, since there is no guarantee that getname use sockaddr_ll
parameter beyond its size, we add a little bit of security here.
It should do not do beyond MAX_ADDR_LEN, but syzbot found that
ax25_getname writes more (72 bytes, the size of full_sockaddr_ax25,
versus 20 + 32 bytes of sockaddr_ll + MAX_ADDR_LEN in syzbot repro).

Fixes: 3a4d5c94e9593 ("vhost_net: a kernel-level virtio server")
Reported-by: syzbot+f2a62d07a5198c819c7b@syzkaller.appspotmail.com
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/vhost/net.c