]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
dm: fix queue start/stop imbalance under suspend/load/resume races
authorZheng Qixing <zhengqixing@huawei.com>
Tue, 26 Aug 2025 07:42:03 +0000 (15:42 +0800)
committerMikulas Patocka <mpatocka@redhat.com>
Tue, 26 Aug 2025 14:46:32 +0000 (16:46 +0200)
commit7f597c2cdb9d3263a6fce07c4fc0a9eaa8e8fc43
treef8874f731eb892e861b1cc262f263cafee26109f
parent1d57628ff95b32d5cfa8d8f50e07690c161e9cf0
dm: fix queue start/stop imbalance under suspend/load/resume races

When suspend and load run concurrently, before q->mq_ops is set in
blk_mq_init_allocated_queue(), __dm_suspend() skip dm_stop_queue(). As a
result, the queue's quiesce depth is not incremented.

Later, once table load has finished and __dm_resume() runs, which triggers
q->quiesce_depth ==0 warning in blk_mq_unquiesce_queue():
Call Trace:
 <TASK>
 dm_start_queue+0x16/0x20 [dm_mod]
 __dm_resume+0xac/0xb0 [dm_mod]
 dm_resume+0x12d/0x150 [dm_mod]
 do_resume+0x2c2/0x420 [dm_mod]
 dev_suspend+0x30/0x130 [dm_mod]
 ctl_ioctl+0x402/0x570 [dm_mod]
 dm_ctl_ioctl+0x23/0x30 [dm_mod]

Fix this by explicitly tracking whether the request queue was
stopped in __dm_suspend() via a new DMF_QUEUE_STOPPED flag.
Only call dm_start_queue() in __dm_resume() if the queue was
actually stopped.

Fixes: e70feb8b3e68 ("blk-mq: support concurrent queue quiesce/unquiesce")
Cc: stable@vger.kernel.org
Signed-off-by: Zheng Qixing <zhengqixing@huawei.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
drivers/md/dm-core.h
drivers/md/dm.c