]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Suppress complaints about leaks in TS dictionary loading.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 2 Aug 2025 23:43:53 +0000 (19:43 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 3 Aug 2025 01:59:46 +0000 (21:59 -0400)
commit7f6ededa764b287ba593a2bb7fd566df8053213e
treeada62ee844caa2ee85aa3e17eccb5e8522177641
parent2c7b4ad24dda86a73d80df063e9a56c3ecb1e4bb
Suppress complaints about leaks in TS dictionary loading.

Like the situation with function cache loading, text search
dictionary loading functions tend to leak some cruft into the
dictionary's long-lived cache context.  To judge by the examples in
the core regression tests, not very many bytes are at stake.
Moreover, I don't see a way to prevent such leaks without changing the
API for TS template initialization functions: right now they do not
have to worry about making sure that their results are long-lived.

Hence, I think we should install a suppression rule rather than trying
to fix this completely.  However, I did grab some low-hanging fruit:
several places were leaking the result of get_tsearch_config_filename.
This seems worth doing mostly because they are inconsistent with other
dictionaries that were freeing it already.

Author: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/285483.1746756246@sss.pgh.pa.us
src/backend/tsearch/dict_ispell.c
src/backend/tsearch/dict_synonym.c
src/backend/tsearch/dict_thesaurus.c
src/backend/utils/cache/ts_cache.c
src/tools/valgrind.supp