]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
media: s5p-mfc: remove an unused/uninitialized variable
authorArnd Bergmann <arnd@arndb.de>
Thu, 7 Aug 2025 20:54:15 +0000 (22:54 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 29 Aug 2025 09:04:02 +0000 (11:04 +0200)
commit7fa37ba25a1dfc084e24ea9acc14bf1fad8af14c
tree5d1e87606abaf3738d7c2902458f3e96d958a5ed
parentb4c441310c3baaa7c39a5457e305ca93c7a0400d
media: s5p-mfc: remove an unused/uninitialized variable

The s5p_mfc_cmd_args structure in the v6 driver is never used, not
initialized to anything other than zero, but as of clang-21 this
causes a warning:

drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd_v6.c:45:7: error: variable 'h2r_args' is uninitialized when passed as a const pointer argument here [-Werror,-Wuninitialized-const-pointer]
   45 |                                         &h2r_args);
      |                                          ^~~~~~~~

Just remove this for simplicity. Since the function is also called
through a callback, this does require adding a trivial wrapper with
the correct prototype.

Fixes: f96f3cfa0bb8 ("[media] s5p-mfc: Update MFC v4l2 driver to support MFC6.x")
Cc: stable@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd_v6.c