]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/mlx5: Fix command entry leak in Internal Error State
authorMoshe Shemesh <moshe@mellanox.com>
Sun, 23 Feb 2020 01:27:41 +0000 (03:27 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 May 2020 06:15:26 +0000 (08:15 +0200)
commit7fb0515467c87a2589c3be163ed214933db8a46f
treef74561a27fd6f4fe1b210d23cbbbc96e99355b8e
parentc393b5917b18575fbd2fee7771244930e795b7da
net/mlx5: Fix command entry leak in Internal Error State

[ Upstream commit cece6f432cca9f18900463ed01b97a152a03600a ]

Processing commands by cmd_work_handler() while already in Internal
Error State will result in entry leak, since the handler process force
completion without doorbell. Forced completion doesn't release the entry
and event completion will never arrive, so entry should be released.

Fixes: 73dd3a4839c1 ("net/mlx5: Avoid using pending command interface slots")
Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/mellanox/mlx5/core/cmd.c