]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
random32: Fix implicit truncation warning in prandom_seed_state()
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Tue, 25 May 2021 12:20:12 +0000 (13:20 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:15:46 +0000 (16:15 +0200)
commit7fb82d7854198d15ee3f87c255e10ec8c9fe0347
treec742e694ca530657847702e5fcbc7b225aef38c9
parentd5473f43e4fb27550512bebf62d029f4850b4b3d
random32: Fix implicit truncation warning in prandom_seed_state()

[ Upstream commit d327ea15a305024ef0085252fa3657bbb1ce25f5 ]

sparse generates the following warning:

 include/linux/prandom.h:114:45: sparse: sparse: cast truncates bits from
 constant value

This is because the 64-bit seed value is manipulated and then placed in a
u32, causing an implicit cast and truncation. A forced cast to u32 doesn't
prevent this warning, which is reasonable because a typecast doesn't prove
that truncation was expected.

Logical-AND the value with 0xffffffff to make explicit that truncation to
32-bit is intended.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20210525122012.6336-3-rf@opensource.cirrus.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/linux/prandom.h