]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
octeon_ep: Fix memory leak in octep_device_setup()
authorZilin Guan <zilin@seu.edu.cn>
Wed, 21 Jan 2026 13:05:51 +0000 (13:05 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 23 Jan 2026 19:45:36 +0000 (11:45 -0800)
commit8016dc5ee19a77678c264f8ba368b1e873fa705b
treed28422adf82c3b0edb9f6a9682cdddb89cac436f
parent6de4436bf369e1444606445e4cd5df5bcfc74b48
octeon_ep: Fix memory leak in octep_device_setup()

In octep_device_setup(), if octep_ctrl_net_init() fails, the function
returns directly without unmapping the mapped resources and freeing the
allocated configuration memory.

Fix this by jumping to the unsupported_dev label, which performs the
necessary cleanup. This aligns with the error handling logic of other
paths in this function.

Compile tested only. Issue found using a prototype static analysis tool
and code review.

Fixes: 577f0d1b1c5f ("octeon_ep: add separate mailbox command and response queues")
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/20260121130551.3717090-1-zilin@seu.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeon_ep/octep_main.c