]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cifs: Fix buffer overflow when parsing NFS reparse points
authorPali Rohár <pali@kernel.org>
Sun, 29 Sep 2024 10:22:40 +0000 (12:22 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Oct 2024 10:00:12 +0000 (12:00 +0200)
commit803b3a39cb096d8718c0aebc03fd19f11c7dc919
treea78857bbc577bfa3e52bf6da73cd9c7791399e08
parent16e0267db156f8a4ea16bfb3ac3f5743c9698df3
cifs: Fix buffer overflow when parsing NFS reparse points

[ Upstream commit e2a8910af01653c1c268984855629d71fb81f404 ]

ReparseDataLength is sum of the InodeType size and DataBuffer size.
So to get DataBuffer size it is needed to subtract InodeType's size from
ReparseDataLength.

Function cifs_strndup_from_utf16() is currentlly accessing buf->DataBuffer
at position after the end of the buffer because it does not subtract
InodeType size from the length. Fix this problem and correctly subtract
variable len.

Member InodeType is present only when reparse buffer is large enough. Check
for ReparseDataLength before accessing InodeType to prevent another invalid
memory access.

Major and minor rdev values are present also only when reparse buffer is
large enough. Check for reparse buffer size before calling reparse_mkdev().

Fixes: d5ecebc4900d ("smb3: Allow query of symlinks stored as reparse points")
Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/smb/client/reparse.c