]> git.ipfire.org Git - thirdparty/patchwork.git/commit
parser: fix parsing of patches with headings
authorJiri Benc <jbenc@redhat.com>
Thu, 28 Jun 2018 19:42:11 +0000 (15:42 -0400)
committerStephen Finucane <stephen@that.guru>
Sun, 14 Oct 2018 13:42:39 +0000 (14:42 +0100)
commit8060b9a6719bcfe80f7f23143447167dc02c23d5
tree0714f1a5e45748da1e22da0092c4253ba270803c
parent4159ba3176d56934a44c9146984adf19a4d20b03
parser: fix parsing of patches with headings

Some people tend to use lines full of '=' as a fancy way to format headings
in their commit messages in a rst-like style. However, the current parser
treats such lines as a beginning of a diff.

The only currently used tool that produces diffs with '=' lines is quilt in
the default configuration. However, even with quilt, the diff looks this
way:

    Index: dir/file
    ===================================================================
    --- dir.orig/file
    +++ dir/file
    @@ ...etc...

It's enough to match on the "Index:" line. The state of the state machine is
kept at 1 when it encounters the '=' line, thus it's safe to remove the
match on '=' completely.

[This prevents us from properly parsing metadata out of the changelog. -dcz ]

Signed-off-by: Jiri Benc <jbenc@redhat.com>
Reviewed-by: Stephen Finucane <stephen@that.guru>
(cherry picked from commit 67faf96ab96d93252c89967ef766bcbe8214c0fc)
patchwork/parser.py