]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-38530: Refactor and improve AttributeError suggestions (GH-25776)
authorDennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
Mon, 3 May 2021 15:47:27 +0000 (11:47 -0400)
committerGitHub <noreply@github.com>
Mon, 3 May 2021 15:47:27 +0000 (16:47 +0100)
commit80a2a4ed7d090fff2584302f07315d567109bca9
treecfaec858b722cf629fdb488a02baeb8e823bf185
parentc715b524210050bdd2a2e233817246d443bbb236
bpo-38530: Refactor and improve AttributeError suggestions (GH-25776)

- Make case-swaps half the cost of any other edit
- Refactor Levenshtein code to not use memory allocator, and to bail early on no match.
- Add comments to Levenshtein distance code
- Add test cases for Levenshtein distance behind a debug macro
- Set threshold to `(name_size + item_size + 3) * MOVE_COST / 6`.
  - Reasoning: similar to `difflib.SequenceMatcher.ratio()` >= 2/3:
```
"Multiset Jaccard similarity" >= 2/3
matching letters / total letters >= 2/3
(name_size - distance + item_size - distance) / (name_size + item_size) >= 2/3
1 - (2*distance) / (name_size + item_size) >= 2/3
1/3 >= (2*distance) / (name_size + item_size)
(name_size + item_size) / 6 >= distance
With rounding:
(name_size + item_size + 3) // 6 >= distance
```

Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
Include/internal/pycore_pyerrors.h
Lib/test/test_exceptions.py
Modules/_testinternalcapi.c
Python/suggestions.c