]> git.ipfire.org Git - thirdparty/postgresql.git/commit
WAL-log the creation of the init fork of unlogged indexes.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 6 Jul 2023 14:25:29 +0000 (17:25 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 6 Jul 2023 14:29:15 +0000 (17:29 +0300)
commit80abec3870692454c42b6b809f4b26cf72ea0736
tree06b166526dbba3629947157ff8588ab3d01f9bfc
parent162aa47c31a0236d68b68d65df3fef0079af0d48
WAL-log the creation of the init fork of unlogged indexes.

We create a file, so we better WAL-log it. In practice, all the
built-in index AMs and all extensions that I'm aware of write a
metapage to the init fork, which is WAL-logged, and replay of the
metapage implicitly creates the fork too. But if ambuildempty() didn't
write any page, we would miss it.

This can be seen with dummy_index_am. Set up replication, create a
'dummy_index_am' index on an unlogged table, and look at the files
created in the replica: the init fork is not created on the
replica. Dummy_index_am doesn't do anything with the relation files,
however, so it doesn't lead to any user-visible errors.

Backpatch to all supported versions.

Reviewed-by: Robert Haas
Discussion: https://www.postgresql.org/message-id/6e5bbc08-cdfc-b2b3-9e23-1a914b9850a9%40iki.fi
src/backend/catalog/index.c