]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/aspeed: Convert to platform remove callback returning void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sun, 7 May 2023 16:25:28 +0000 (18:25 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Nov 2023 10:57:00 +0000 (11:57 +0100)
commit813ef38bb98b142619a2b939c74e25105b98ca8f
treea85ce99b684329a24cae44b7fa11fd9db0cfb115
parentb53575a965c9d7b7997ecc75a59438603e27f164
drm/aspeed: Convert to platform remove callback returning void

[ Upstream commit 9a32dd324c46a0c76cac9d91e5a88abcf83f7b03 ]

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230507162616.1368908-6-u.kleine-koenig@pengutronix.de
Stable-dep-of: 3c4babae3c4a ("drm: Call drm_atomic_helper_shutdown() at shutdown/remove time for misc drivers")
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/aspeed/aspeed_gfx_drv.c