]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
xen/scsiback: use lateeoi irq binding
authorJuergen Gross <jgross@suse.com>
Tue, 3 Nov 2020 14:29:05 +0000 (15:29 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Nov 2020 17:28:01 +0000 (18:28 +0100)
commit81432d5da7ec727f07bec1ed06bbcfce1f01e03c
tree94cd2f8f4eec652336955ebf91d2b9ac4c8a71f7
parent0cad6b264e35cc31de99c58ed11e42ba6e06d80f
xen/scsiback: use lateeoi irq binding

commit 86991b6e7ea6c613b7692f65106076943449b6b7 upstream.

In order to reduce the chance for the system becoming unresponsive due
to event storms triggered by a misbehaving scsifront use the lateeoi
irq binding for scsiback and unmask the event channel only just before
leaving the event handling function.

In case of a ring protocol error don't issue an EOI in order to avoid
the possibility to use that for producing an event storm. This at once
will result in no further call of scsiback_irq_fn(), so the ring_error
struct member can be dropped and scsiback_do_cmd_fn() can signal the
protocol error via a negative return value.

This is part of XSA-332.

Cc: stable@vger.kernel.org
Reported-by: Julien Grall <julien@xen.org>
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Wei Liu <wl@xen.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/xen/xen-scsiback.c