]> git.ipfire.org Git - thirdparty/grub.git/commit
ieee1275: Drop len -= 1 quirk in heap_init
authorDaniel Axtens <dja@axtens.net>
Mon, 6 Feb 2023 15:03:21 +0000 (10:03 -0500)
committerDaniel Kiper <daniel.kiper@oracle.com>
Tue, 7 Mar 2023 14:18:47 +0000 (15:18 +0100)
commit81b0b1cea403de47fde06877acb911a66e681000
tree70f0ace4d93adef4e209af8b585516aaceeb328a
parentb5fd45a50f3cda1f7ff0d8da05dd5841e0474352
ieee1275: Drop len -= 1 quirk in heap_init

This was apparently "required by some firmware": commit dc9468500919
(2007-02-12  Hollis Blanchard  <hollis@penguinppc.org>).

It's not clear what firmware that was, and what platform from 14 years ago
which exhibited the bug then is still both in use and buggy now.

It doesn't cause issues on qemu (mac99 or pseries) or under PFW for Power8.

I don't have access to old Mac hardware, but if anyone feels especially
strongly we can put it under some feature flag. I really want to disable
it under pseries because it will mess with region merging.

Signed-off-by: Daniel Axtens <dja@axtens.net>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Tested-by: Nageswara R Sastry <rnsastry@linux.ibm.com>
Reviewed-by: Robbie Harwood <rharwood@redhat.com>
grub-core/kern/ieee1275/init.c