]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nvmet: fix ns enable/disable possible hang
authorSagi Grimberg <sagi@grimberg.me>
Tue, 21 May 2024 20:20:28 +0000 (23:20 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jun 2024 11:39:49 +0000 (13:39 +0200)
commit81f9b2a9a8c52d1c154cfc9bb957fcf556428ea9
tree4c15480e61d3e48bf2e215300ac95219e8817d93
parentb41b0018e8ca06e985e87220a618ec633988fd13
nvmet: fix ns enable/disable possible hang

[ Upstream commit f97914e35fd98b2b18fb8a092e0a0799f73afdfe ]

When disabling an nvmet namespace, there is a period where the
subsys->lock is released, as the ns disable waits for backend IO to
complete, and the ns percpu ref to be properly killed. The original
intent was to avoid taking the subsystem lock for a prolong period as
other processes may need to acquire it (for example new incoming
connections).

However, it opens up a window where another process may come in and
enable the ns, (re)intiailizing the ns percpu_ref, causing the disable
sequence to hang.

Solve this by taking the global nvmet_config_sem over the entire configfs
enable/disable sequence.

Fixes: a07b4970f464 ("nvmet: add a generic NVMe target")
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/nvme/target/configfs.c