]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Revert "vgacon: Add check for vc_origin address range in vgacon_scroll()"
authorHelge Deller <deller@gmx.de>
Sat, 2 Aug 2025 19:34:37 +0000 (21:34 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:28:33 +0000 (16:28 +0200)
commit820949bbf33f3e8892c90c772a52f4082ea8d8f0
tree330e4a381e30ba1522c9d158dea6e29a635f278b
parent5858448a6c65d8ee3f8600570d3ce19febcb33be
Revert "vgacon: Add check for vc_origin address range in vgacon_scroll()"

commit e4fc307d8e24f122402907ebf585248cad52841d upstream.

This reverts commit 864f9963ec6b4b76d104d595ba28110b87158003.

The patch is wrong as it checks vc_origin against vc_screenbuf,
while in text mode it should compare against vga_vram_base.

As such it broke VGA text scrolling, which can be reproduced like this:
(1) boot a kernel that is configured to use text mode VGA-console
(2) type commands:  ls -l /usr/bin | less -S
(3) scroll up/down with cursor-down/up keys

Reported-by: Jari Ruusu <jariruusu@protonmail.com>
Cc: stable@vger.kernel.org
Cc: Yi Yang <yiyang13@huawei.com>
Cc: GONG Ruiqi <gongruiqi1@huawei.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/video/console/vgacon.c