]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: ipip: require CAP_NET_ADMIN in the device netns for changelink
authorMaoyi Xie <maoyixie.tju@gmail.com>
Fri, 12 Jun 2026 08:59:36 +0000 (16:59 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 17 Jun 2026 23:01:52 +0000 (16:01 -0700)
commit8211a26324667980a463c069469a818e71207e02
treeb1ff802bd3199c3a13d4b90dcdf6199571aaa75e
parent8165f7ff57d9667d2bb477ef6af83ede7fed4ad7
net: ipip: require CAP_NET_ADMIN in the device netns for changelink

ipip_changelink() operates on at most two netns, dev_net(dev) and the
tunnel link netns t->net. They differ once the device is created in or
moved to a netns other than the one the request runs in. The rtnl
changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a
caller privileged there but not in t->net can rewrite a tunnel that
lives in t->net.

Gate ipip_changelink() on rtnl_dev_link_net_capable() at its top,
before any attribute is parsed.

Reported-by: Xiao Liang <shaw.leon@gmail.com>
Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/
Fixes: 6c742e714d8c ("ipip: add x-netns support")
Cc: stable@vger.kernel.org
Signed-off-by: Maoyi Xie <maoyixie.tju@gmail.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20260612085941.3158249-3-maoyixie.tju@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/ipip.c