]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
irqchip/gicv3: Handle loop timeout proper
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 14 Oct 2016 07:26:21 +0000 (10:26 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Oct 2016 07:45:28 +0000 (03:45 -0400)
commit82301da7eb625228ae021add4ac9f178e9b3b8ba
treea969dfbc3fc04e752eea495f2291af485ec75f52
parent2bb293cb8254d579ab831c38585d58444cf421dd
irqchip/gicv3: Handle loop timeout proper

commit d102eb5c1ac5e6743b1c6d145c06a25d98ad1375 upstream.

The timeout loop terminates when the loop count is zero, but the decrement
of the count variable is post check. So count is -1 when we check for the
timeout and therefor the error message is supressed.

Change it to predecrement, so the error message is emitted.

[ tglx: Massaged changelog ]

Fixes: a2c225101234 ("irqchip: gic-v3: Refactor gic_enable_redist to support both enabling and disabling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: kernel-janitors@vger.kernel.org
Cc: Jason Cooper <jason@lakedaemon.net>
Link: http://lkml.kernel.org/r/20161014072534.GA15168@mwanda
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/irqchip/irq-gic-v3.c