]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: hda/hdmi: Fix breakage at probing nvhdmi-mcp driver
authorTakashi Iwai <tiwai@suse.de>
Thu, 6 Nov 2025 10:46:45 +0000 (11:46 +0100)
committerTakashi Iwai <tiwai@suse.de>
Thu, 6 Nov 2025 10:49:35 +0000 (11:49 +0100)
commit82420bd4e17bdaba8453fbf9e10c58c9ed0c9727
tree51bbd2b6fd52a960f79ec703cbbcffef118a7f5e
parentb98b69c38512c3a8277c83b2d07674fd1ff59625
ALSA: hda/hdmi: Fix breakage at probing nvhdmi-mcp driver

After restructuring and splitting the HDMI codec driver code, each
HDMI codec driver contains the own build_controls and build_pcms ops.
A copy-n-paste error put the wrong entries for nvhdmi-mcp driver; both
build_controls and build_pcms are swapped.  Unfortunately both
callbacks have the very same form, and the compiler didn't complain
it, either.  This resulted in a NULL dereference because the PCM
instance hasn't been initialized at calling the build_controls
callback.

Fix it by passing the proper entries.

Fixes: ad781b550f9a ("ALSA: hda/hdmi: Rewrite to new probe method")
Cc: <stable@vger.kernel.org>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=220743
Link: https://patch.msgid.link/20251106104647.25805-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/hda/codecs/hdmi/nvhdmi-mcp.c