]> git.ipfire.org Git - thirdparty/libvirt.git/commit
tools: avoid accidentally using files from gnulib
authorDaniel P. Berrangé <berrange@redhat.com>
Thu, 8 Aug 2019 09:23:26 +0000 (10:23 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Thu, 8 Aug 2019 12:32:02 +0000 (13:32 +0100)
commit8242ce4f45700f326e13e5105accd08fb4b2f0b4
tree27052d93c0bb00ae8f5bdc6de855ba40694960d3
parent05fb5f5af29c0169243928a93bbdc48cc0e87e4d
tools: avoid accidentally using files from gnulib

The AM_CPPFLAGS setting includes the gnulib headers, which
means we can get some replacement functions defined. Since
virt-login-shell and the NSS module intentionally don't link
to gnulib, these replacement functions causes link failures.

This was seen cross-compiling on Debian for example:

virt-login-shell.o: In function `main':
/builds/libvirt/libvirt/build/tools/../../tools/virt-login-shell.c:81: undefined reference to `rpl_strerror'
/builds/libvirt/libvirt/build/tools/../../tools/virt-login-shell.c:66: undefined reference to `rpl_strerror'
/builds/libvirt/libvirt/build/tools/../../tools/virt-login-shell.c:75: undefined reference to `rpl_strerror'

The only way to avoid these replacement gnulib headers is
to drop the -Ignulib/lib flags. We do still want to use
gnulib for configmake.h and intprops.h, but those can be
included via their full path.

We must also stop using internal.h, since that expects
-Ignulib/lib to be on the include path in order to resolve
the verify.h header.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
cfg.mk
tools/Makefile.am
tools/nss/libvirt_nss.c
tools/nss/libvirt_nss_leases.c
tools/nss/libvirt_nss_leases.h
tools/nss/libvirt_nss_macs.c
tools/nss/libvirt_nss_macs.h
tools/virt-login-shell.c