]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ipv4: try to cache dst_entries which would cause a redirect
authorHannes Frederic Sowa <hannes@stressinduktion.org>
Fri, 23 Jan 2015 11:01:26 +0000 (12:01 +0100)
committerJiri Slaby <jslaby@suse.cz>
Tue, 10 Feb 2015 10:16:49 +0000 (11:16 +0100)
commit8277cc54f4245d71a00acba3672616c1e3b4dc65
treec3a74140c4f3453319b413245da38c53e6e70ebc
parent43e39c2f63240f67a67b4060882f67dac1a6f339
ipv4: try to cache dst_entries which would cause a redirect

[ Upstream commit df4d92549f23e1c037e83323aff58a21b3de7fe0 ]

Not caching dst_entries which cause redirects could be exploited by hosts
on the same subnet, causing a severe DoS attack. This effect aggravated
since commit f88649721268999 ("ipv4: fix dst race in sk_dst_get()").

Lookups causing redirects will be allocated with DST_NOCACHE set which
will force dst_release to free them via RCU.  Unfortunately waiting for
RCU grace period just takes too long, we can end up with >1M dst_entries
waiting to be released and the system will run OOM. rcuos threads cannot
catch up under high softirq load.

Attaching the flag to emit a redirect later on to the specific skb allows
us to cache those dst_entries thus reducing the pressure on allocation
and deallocation.

This issue was discovered by Marcelo Leitner.

Cc: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Marcelo Leitner <mleitner@redhat.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
include/net/ip.h
net/ipv4/ip_forward.c
net/ipv4/route.c