]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
virtio_console: fix order of fields cols and rows
authorMaximilian Immanuel Brandtner <maxbr@linux.ibm.com>
Mon, 24 Mar 2025 14:42:46 +0000 (15:42 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 11 Jan 2026 14:25:21 +0000 (15:25 +0100)
commit828b59fdf8ef22ab2d59ce349d16231723692b50
tree78a642a1ec878e63c5cd9ac11087aa7682523289
parent1b9c118fe318a43aed0b8a516b23817cd3623cf8
virtio_console: fix order of fields cols and rows

commit 5326ab737a47278dbd16ed3ee7380b26c7056ddd upstream.

According to section 5.3.6.2 (Multiport Device Operation) of the virtio
spec(version 1.2) a control buffer with the event VIRTIO_CONSOLE_RESIZE
is followed by a virtio_console_resize struct containing cols then rows.
The kernel implements this the wrong way around (rows then cols) resulting
in the two values being swapped.

Signed-off-by: Maximilian Immanuel Brandtner <maxbr@linux.ibm.com>
Message-Id: <20250324144300.905535-1-maxbr@linux.ibm.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Cc: Filip Hejsek <filip.hejsek@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/virtio_console.c