]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
[3.11] gh-108987: Fix _thread.start_new_thread() race condition (#109135) (#109272)
authorVictor Stinner <vstinner@python.org>
Mon, 11 Sep 2023 17:33:08 +0000 (19:33 +0200)
committerGitHub <noreply@github.com>
Mon, 11 Sep 2023 17:33:08 +0000 (19:33 +0200)
commit82a18069a1c288b9be3cdaf63a04e4c77fbd231f
tree219c98c62906504ef043217f78c027dccef95683
parent9297a72dbd39aca99fa8cf92960ce1869bc51c0b
[3.11] gh-108987: Fix _thread.start_new_thread() race condition (#109135) (#109272)

gh-108987: Fix _thread.start_new_thread() race condition (#109135)

Fix _thread.start_new_thread() race condition. If a thread is created
during Python finalization, the newly spawned thread now exits
immediately instead of trying to access freed memory and lead to a
crash.

thread_run() calls PyEval_AcquireThread() which checks if the thread
must exit. The problem was that tstate was dereferenced earlier in
_PyThreadState_Bind() which leads to a crash most of the time.

Move _PyThreadState_CheckConsistency() from thread_run() to
_PyThreadState_Bind().

(cherry picked from commit 517cd82ea7d01b344804413ef05610934a43a241)
Include/internal/pycore_pystate.h
Misc/NEWS.d/next/Library/2023-09-08-12-09-55.gh-issue-108987.x5AIG8.rst [new file with mode: 0644]
Modules/_threadmodule.c
Python/ceval_gil.h
Python/pystate.c