]> git.ipfire.org Git - thirdparty/openwrt.git/commit
uboot-mediatek: u7623: remove keys pin function
authorTomasz Maciej Nowak <tmn505@gmail.com>
Tue, 4 Mar 2025 16:43:10 +0000 (17:43 +0100)
committerHauke Mehrtens <hauke@hauke-m.de>
Mon, 17 Mar 2025 15:21:23 +0000 (16:21 +0100)
commit82fabe43709da2d7f744e8e05ab19317420c8063
treef8c02871541d8217f45ff25af0876a57c68e619e
parent3c1edff2938e6055331d2934f50fa478703ba07c
uboot-mediatek: u7623: remove keys pin function

Apparently U-Boot will discard whole node if requested pin function is
unknown to the driver. This resulted in inability to interact with
U-Boot on the said board, as U-Boot always assumed the recovery key
pressed and issued recovery procedure. Log snippet:

button_gpio gpio-keys: pinctrl_select_state_full: pinctrl_config_one: err=-38
reset button found
button pushed, resetting environment

Recovery procedure also booted recovery image, which didn't affect much
the 23.05.x release, since the root fs argument was valid, so changes
persisted. But as 24.10.x hit with fitblk, the board will boot only
recovery image (initramfs) because of default bootargs will reset on each
boot and U-Boot provided bootargs took precedence.

Fixes: 42eeb22450f2 ("uboot-mediatek: fix factory/reset button")
Signed-off-by: Tomasz Maciej Nowak <tmn505@gmail.com>
Link: https://patchwork.ozlabs.org/project/openwrt/patch/20250304164507.60511-1-tmn505@terefe.re/
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
(cherry picked from commit f8a2e1c68b48d72234172543f4232e77f065ca4d)
package/boot/uboot-mediatek/patches/401-update-u7623-defconfig.patch