]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
efi/libstub: Avoid physical address 0x0 when doing random allocation
authorArd Biesheuvel <ardb@kernel.org>
Fri, 14 Mar 2025 11:03:33 +0000 (12:03 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Mar 2025 21:03:30 +0000 (22:03 +0100)
commit8332847875f75f91e8de1e518fb63441a1dc782d
tree82e0fa13360fd274737bf280f5d75fabd4d5bf85
parentc4e37b381a7a243c298a4858fc0a5a74e737c79a
efi/libstub: Avoid physical address 0x0 when doing random allocation

commit cb16dfed0093217a68c0faa9394fa5823927e04c upstream.

Ben reports spurious EFI zboot failures on a system where physical RAM
starts at 0x0. When doing random memory allocation from the EFI stub on
such a platform, a random seed of 0x0 (which means no entropy source is
available) will result in the allocation to be placed at address 0x0 if
sufficient space is available.

When this allocation is subsequently passed on to the decompression
code, the 0x0 address is mistaken for NULL and the code complains and
gives up.

So avoid address 0x0 when doing random allocation, and set the minimum
address to the minimum alignment.

Cc: <stable@vger.kernel.org>
Reported-by: Ben Schneider <ben@bens.haus>
Tested-by: Ben Schneider <ben@bens.haus>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/efi/libstub/randomalloc.c