]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
Revert "gfs2: don't stop reads while withdraw in progress"
authorAndreas Gruenbacher <agruenba@redhat.com>
Fri, 25 Jul 2025 20:06:56 +0000 (22:06 +0200)
committerAndreas Gruenbacher <agruenba@redhat.com>
Wed, 26 Nov 2025 23:52:26 +0000 (23:52 +0000)
commit833c93caea00b0aef3e22a08fd20acacf212b6fc
tree3c176413b729ef9d05f8f72fb7a45c4b89c1f8b0
parent1714e8543dbe21bbd33e62df926552f943f8f5cd
Revert "gfs2: don't stop reads while withdraw in progress"

The current withdraw code duplicates the journal recovery code gfs2
already has for dealing with node failures, and it does so poorly.  That
code was added because when releasing a lockspace, we didn't have a way
to indicate that the lockspace needs recovery.  We now do have this
feature, so the current withdraw code can be removed almost entirely.
This is one of several steps towards that.

The withdrawing node has no role in recovering from the withdraw
anymore, so it also no longer needs to read metadata blocks after a
withdraw.

We now only need to set a single bit in gfs2_withdraw(), so switch from
try_cmpxchg() to test_and_set_bit().

Reverts commit 8cc67f704f4b ("gfs2: don't stop reads while withdraw in
progress").

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/incore.h
fs/gfs2/meta_io.c
fs/gfs2/sys.c
fs/gfs2/util.c
fs/gfs2/util.h