]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Fri, 3 Sep 2021 07:35:43 +0000 (15:35 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 09:48:14 +0000 (11:48 +0200)
commit833ffc44049435ab0e9b636a671c2108acfbc72a
tree922200b3bd605304d30eb87bed471e6dc68cd506
parent7c113506163a1ec6157927428eddd80038d2916e
qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom

[ Upstream commit 9ddbc2a00d7f63fa9748f4278643193dac985f2d ]

Previous commit 68233c583ab4 removes the qlcnic_rom_lock()
in qlcnic_pinit_from_rom(), but remains its corresponding
unlock function, which is odd. I'm not very sure whether the
lock is missing, or the unlock is redundant. This bug is
suggested by a static analysis tool, please advise.

Fixes: 68233c583ab4 ("qlcnic: updated reset sequence")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c