]> git.ipfire.org Git - thirdparty/openssl.git/commit
Fix incorrect error branch in ossl_bn_rsa_fips186_4_derive_prime()
authorndossche <niels.dossche@ugent.be>
Mon, 13 Feb 2023 14:27:25 +0000 (15:27 +0100)
committerTodd Short <todd.short@me.com>
Mon, 20 Feb 2023 15:19:58 +0000 (10:19 -0500)
commit835b90a19cdb2901cdba8a26955ccaacf0d73062
tree093757e26f7528369c2cf3c7c15880ac0535b422
parent1dbfd7fe24bcd50117bc57942b2046e483a3c5a5
Fix incorrect error branch in ossl_bn_rsa_fips186_4_derive_prime()

BN_priv_rand_range_ex() and BN_add() both return a 0 on failure and a 1
on success. In case of failure, the algorithm should fail. However, the
branch that it goes through on failure is "goto end", not "goto err".
Therefore, the algorithm will return 1 which indicates success instead
of 0 for failure, leading to potential problems for the callers.
Fix it by changing the goto to "goto err" instead of "goto end".

CLA: trivial

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from https://github.com/openssl/openssl/pull/20279)
crypto/bn/bn_rsa_fips186_4.c