]> git.ipfire.org Git - thirdparty/linux.git/commit
perf pmu: Fix pmu_id() heap underwrite on empty identifier file
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 8 Jun 2026 00:01:43 +0000 (21:01 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 10 Jun 2026 21:56:01 +0000 (18:56 -0300)
commit836455e6dbd34eb3d12eeab5e2d2b9a7f1512459
treed7435b3a99cddf3f0b239e0e894f2ff3207619c0
parent2f4e244b5968b1f7392d7de31dc961ef80f2e42e
perf pmu: Fix pmu_id() heap underwrite on empty identifier file

pmu_id() calls filename__read_str() then strips the trailing newline
via str[len - 1] = 0.  If the PMU identifier file is empty,
filename__read_str() succeeds with len = 0.  len - 1 underflows
size_t to SIZE_MAX, writing a null byte before the heap allocation.

Add a len == 0 check before the newline stripping.

Fixes: 51d548471510843e ("perf pmu: Add pmu_id()")
Reported-by: sashiko-bot <sashiko-bot@kernel.org>
Cc: John Garry <john.g.garry@oracle.com>
Assisted-by: Claude:claude-opus-4.6
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/pmu.c