]> git.ipfire.org Git - thirdparty/openssl.git/commit
Fix buggy stringop-overflow error on s390
authorNeil Horman <nhorman@openssl.org>
Fri, 20 Jun 2025 14:22:10 +0000 (10:22 -0400)
committerNeil Horman <nhorman@openssl.org>
Fri, 20 Jun 2025 15:00:08 +0000 (11:00 -0400)
commit837592dcd994a22a7c8d08bf3cf421f6b2e51280
treeb62c510e157f36fbe0a5734868e571c5bd676b76
parent4a341e083011c5329dc327745cb671eef917cb0f
Fix buggy stringop-overflow error on s390

Despite some recent changes to our s390 builds, we're still seeing
errors due to some stringop-overflow warnings:
https://github.com/openssl/openssl/actions/runs/15748518222/job/44389197443

It appears to be caused because the static analysis that gcc preforms in
gcc 12 (the version of the compiler on our s390 runner), fails to infer
the proper sizes of the buffer on which we do the reverse memcpy in
swap_copy(), resulting in warnings, which on --strict-warnings builds,
breaks us.

Fix it by using inlen rather than outlen to limit the copy length,
adjusting it if need be to match the size of the output buffer in
le_copy().  This allows the compiler to properly infer the array length
constraints and suppress the warnings.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/27864)
test/params_api_test.c