]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
Fix parameter-less template regression in new DWARF reader
authorTom Tromey <tromey@adacore.com>
Wed, 14 Dec 2022 21:37:41 +0000 (14:37 -0700)
committerTom Tromey <tromey@adacore.com>
Tue, 17 Jan 2023 14:07:00 +0000 (07:07 -0700)
commit83d3152401cce0c6fd5cd2d4a140bbf5d89a5d9c
tree1b79a64c16dd565b4adac98a2e96aea9125913bf
parent947b698401f036c8496663f063f7660a87472eb6
Fix parameter-less template regression in new DWARF reader

PR c++/29896 points out a regression in the new DWARF reader.  It does
not properly handle a case like "break fn", where "fn" is a template
function.

This happens because the new index uses strncasecmp to compare.
However, to make this work correctly, we need a custom function that
ignores template parameters.

This patch adds a custom comparison function and fixes the bug.  A new
test case is included.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29896

(cherry picked from commit ac37b79cc440e37fc704d425a6e450afb3c7ee89)
gdb/dwarf2/cooked-index.c
gdb/dwarf2/cooked-index.h
gdb/dwarf2/read.c
gdb/testsuite/gdb.cp/paramless.cc [new file with mode: 0644]
gdb/testsuite/gdb.cp/paramless.exp [new file with mode: 0644]