]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix use-after-free bug in prepare_push_reply()
authorSteffan Karger <steffan@karger.me>
Wed, 19 Oct 2016 19:24:20 +0000 (21:24 +0200)
committerGert Doering <gert@greenie.muc.de>
Wed, 19 Oct 2016 20:51:23 +0000 (22:51 +0200)
commit83fdae3e9c482a3d3ceca484d96e1241359a0450
treedef45ea32f27be50a6e9937376c687ff6fe064fc
parenta47d34920a4e6e522592ba7bd0e6ff755aab8c5b
Fix use-after-free bug in prepare_push_reply()

This was introduced by commit dfd3513e, which changes the push_cipher
memory allocation from the options gc to a temporary gc.  For the
ciphername in the options structure, which has to be available longer,
change this back to using the options gc.

Apologies for not spotting this during patch review.

Signed-off-by: Steffan Karger <steffan@karger.me>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1476905060-29896-1-git-send-email-steffan@karger.me>
URL: http://www.mail-archive.com/search?l=mid&q=1476905060-29896-1-git-send-email-steffan@karger.me
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/push.c