]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cdc_ncm: Fix tx_bytes statistics
authorBjørn Mork <bjorn@mork.no>
Fri, 22 May 2015 11:15:22 +0000 (13:15 +0200)
committerSasha Levin <sasha.levin@oracle.com>
Mon, 15 Jun 2015 18:26:50 +0000 (14:26 -0400)
commit842e6e8fe4c5e2fb62abe3a4ba5b213999d39eb3
treed5a176b46b581e60b047757398d2f8e475444bc6
parentfd92b07cb49f8d64efbf25bd344ab1855100b3ad
cdc_ncm: Fix tx_bytes statistics

[ Upstream commit 44f6731d8b68fa02f5ed65eaceac41f8c3c9279e ]

The tx_curr_frame_payload field is u32. When we try to calculate a
small negative delta based on it, we end up with a positive integer
close to 2^32 instead.  So the tx_bytes pointer increases by about
2^32 for every transmitted frame.

Fix by calculating the delta as a signed long.

Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
Reported-by: Florian Bruhin <me@the-compiler.org>
Fixes: 7a1e890e2168 ("usbnet: Fix tx_bytes statistic running backward in cdc_ncm")
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/net/usb/cdc_ncm.c