]> git.ipfire.org Git - thirdparty/openssl.git/commit
Relax checking of supported-groups/keyshare ordering
authorNeil Horman <nhorman@openssl.org>
Tue, 18 Feb 2025 14:01:40 +0000 (09:01 -0500)
committerTomas Mraz <tomas@openssl.org>
Wed, 19 Feb 2025 16:08:53 +0000 (17:08 +0100)
commit84694d2baa964abcd4f3d57a2a85a8369743476c
treebde7792292d519e058f775dd55b6effb7dc955bb
parent20a2f3beba9be6e226a0633b60c29e8a928ccd21
Relax checking of supported-groups/keyshare ordering

quic interop testing showed that interop with the mvfst client was
failing, due to detecting mis ordering of supported groups and keyshare
extensions

This is strictly a mvfst problem to fix, but RFC 8446 indicates that we
MAY check the ordering but don't strictly have to.

We've opened an issue with the client to fix this, but in the interests
of client compatibility relax the ordering check so that, instead of
issuing a fatal alert, we just log a trace message indicating the
discrepancy

Fixes openssl/project#1106

Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/26818)
ssl/statem/extensions_srvr.c