]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
nfs: don't skip revalidate on directory delegation when attrs flagged stale
authorTom Haynes <loghyr@gmail.com>
Sat, 18 Apr 2026 19:03:01 +0000 (12:03 -0700)
committerAnna Schumaker <anna.schumaker@hammerspace.com>
Mon, 15 Jun 2026 19:06:06 +0000 (15:06 -0400)
commit84800a8d1d22c475b3c35bdbcf8ed64a55f3b66f
tree5c19ce9c78923c527ad8a768bff0f4a0fe650964
parent60e7870052f417d83965db144f70ae21fcfcf37f
nfs: don't skip revalidate on directory delegation when attrs flagged stale

On a local directory mutation (rename/create/unlink) the client marks
CHANGE / MTIME / CTIME as invalid in NFS_I(dir)->cache_validity.  When
a subsequent stat(2) enters __nfs_revalidate_inode() and finds a
directory delegation held, the function currently early-exits and
returns the cached (now stale) mtime to userspace without sending a
GETATTR RPC.

Keep the early-exit for the fast path, but take the RPC when CHANGE,
MTIME, or CTIME are already marked invalid.  The delegation alone is
not a guarantee of cached-attr freshness once the code itself has
flagged the cache as stale.

Assisted-by: Claude:claude-opus-4-7 [bpftrace] [tshark]
Signed-off-by: Tom Haynes <loghyr@gmail.com>
[Anna: Use NFS_INO_INVALID_ATTR insteado of individual NFS_INO_INVALID_* flags]
Signed-off-by: Anna Schumaker <anna@kernel.org>
fs/nfs/inode.c