]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix one-off bug causing missing commit timestamps for subtransactions
authorMichael Paquier <michael@paquier.xyz>
Fri, 21 Jan 2022 05:54:47 +0000 (14:54 +0900)
committerMichael Paquier <michael@paquier.xyz>
Fri, 21 Jan 2022 05:54:47 +0000 (14:54 +0900)
commit84db5169d4715904b0bffa25509f3c77fcd52188
tree1a268789f41dae2845bb92e84933aeb16a05a9ad
parentcf680bd6538a5a05020ab4d193b43563e9eb0c5e
Fix one-off bug causing missing commit timestamps for subtransactions

The logic in charge of writing commit timestamps (enabled with
track_commit_timestamp) for subtransactions had a one-bug bug,
where it would be possible that commit timestamps go missing for the
last subtransaction committed.

While on it, simplify a bit the iteration logic in the loop writing the
commit timestamps, as per suggestions from Kyotaro Horiguchi and Tom
Lane, so as some variable initializations are not part of the loop
itself.

Issue introduced in 73c986a.

Analyzed-by: Alex Kingsborough
Author: Alex Kingsborough, Kyotaro Horiguchi
Discussion: https://postgr.es/m/73A66172-4050-4F2A-B7F1-13508EDA2144@amazon.com
Backpatch-through: 10
src/backend/access/transam/commit_ts.c