]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: st: Tighten the page format heuristics with MODE SELECT
authorKai Mäkisara <Kai.Makisara@kolumbus.fi>
Tue, 11 Mar 2025 11:25:16 +0000 (13:25 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Jun 2025 12:37:56 +0000 (14:37 +0200)
commit84e7b679f8d6849b6524b9f4496f1e0eb1552cbb
tree0b82ccf5bcc1e531fbb27c909680b1e9cc79eba6
parentdb03d5b2db5c80e4c8b1463a58c72a2a20bd5244
scsi: st: Tighten the page format heuristics with MODE SELECT

[ Upstream commit 8db816c6f176321e42254badd5c1a8df8bfcfdb4 ]

In the days when SCSI-2 was emerging, some drives did claim SCSI-2 but did
not correctly implement it. The st driver first tries MODE SELECT with the
page format bit set to set the block descriptor.  If not successful, the
non-page format is tried.

The test only tests the sense code and this triggers also from illegal
parameter in the parameter list. The test is limited to "old" devices and
made more strict to remove false alarms.

Signed-off-by: Kai Mäkisara <Kai.Makisara@kolumbus.fi>
Link: https://lore.kernel.org/r/20250311112516.5548-4-Kai.Makisara@kolumbus.fi
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/st.c