]> git.ipfire.org Git - thirdparty/gcc.git/commit
c++: explicit inst w/ similar constrained partial specs [PR104634]
authorPatrick Palka <ppalka@redhat.com>
Mon, 15 Jan 2024 21:53:28 +0000 (16:53 -0500)
committerPatrick Palka <ppalka@redhat.com>
Mon, 15 Jan 2024 21:56:53 +0000 (16:56 -0500)
commit854c9b682562b103f60e5f0a823f31df17a97568
treedab0d2bad54bfe50c13a9e6f0ec0893b16427bbe
parent766ea9da8ccff3786ec5df414046f6b1640e7e01
c++: explicit inst w/ similar constrained partial specs [PR104634]

Here we neglect to emit the definitions of A<double>::f2 and A<double*>::f4
despite the explicit instantiations ultimately because TREE_PUBLIC isn't
set on the corresponding partial specializations, whose declarations are
created from maybe_new_partial_specialization which is responsible for
disambiguating them from the first and third partial specializations (which
have the same class-head but different constraints).  This makes grokfndecl
in turn clear TREE_PUBLIC for f2 and f4 as if they have internal linkage.

This patch fixes this by setting TREE_PUBLIC appropriately for such partial
specializations.

PR c++/104634

gcc/cp/ChangeLog:

* pt.cc (maybe_new_partial_specialization): Propagate TREE_PUBLIC
to the newly created partial specialization.

gcc/testsuite/ChangeLog:

* g++.dg/cpp2a/concepts-explicit-inst6.C: New test.

Reviewed-by: Jason Merrill <jason@redhat.com>
(cherry picked from commit 47673571b28278d857371167f4b67a04a1b87b59)
gcc/cp/pt.cc
gcc/testsuite/g++.dg/cpp2a/concepts-explicit-inst6.C [new file with mode: 0644]