]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: liquidio: Fix off-by-one error in PF setup_nic_devices() cleanup
authorZilin Guan <zilin@seu.edu.cn>
Wed, 28 Jan 2026 15:44:39 +0000 (15:44 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 30 Jan 2026 03:27:35 +0000 (19:27 -0800)
commit8558aef4e8a1a83049ab906d21d391093cfa7e7f
tree27a5f2e4c9d31fc5137da87045d0a1daa6823557
parent926ede0c85e1e57c97d64d9612455267d597bb2c
net: liquidio: Fix off-by-one error in PF setup_nic_devices() cleanup

In setup_nic_devices(), the initialization loop jumps to the label
setup_nic_dev_free on failure. The current cleanup loop while(i--)
skip the failing index i, causing a memory leak.

Fix this by changing the loop to iterate from the current index i
down to 0.

Also, decrement i in the devlink_alloc failure path to point to the
last successfully allocated index.

Compile tested only. Issue found using code review.

Fixes: f21fb3ed364b ("Add support of Cavium Liquidio ethernet adapters")
Suggested-by: Simon Horman <horms@kernel.org>
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Link: https://patch.msgid.link/20260128154440.278369-3-zilin@seu.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/cavium/liquidio/lio_main.c