]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
be2net: Signal that the device cannot transmit during reconfiguration
authorBenjamin Poirier <bpoirier@suse.com>
Tue, 16 Jul 2019 08:16:55 +0000 (17:16 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 6 Aug 2019 16:28:27 +0000 (18:28 +0200)
commit85ba09a0da3e5abe711ad57143c632f0e2d1c5c7
tree6a9ccb9d3fb69a56ae668f34d2db803f0756d2a2
parent9a8b327b7e7b7d3817f20dccac82ad258fbefb8b
be2net: Signal that the device cannot transmit during reconfiguration

[ Upstream commit 7429c6c0d9cb086d8e79f0d2a48ae14851d2115e ]

While changing the number of interrupt channels, be2net stops adapter
operation (including netif_tx_disable()) but it doesn't signal that it
cannot transmit. This may lead dev_watchdog() to falsely trigger during
that time.

Add the missing call to netif_carrier_off(), following the pattern used in
many other drivers. netif_carrier_on() is already taken care of in
be_open().

Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/emulex/benet/be_main.c