]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tcp: reset sk_rx_dst in tcp_disconnect()
authorWANG Cong <xiyou.wangcong@gmail.com>
Sun, 25 Jun 2017 06:50:30 +0000 (23:50 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Jul 2017 05:00:05 +0000 (07:00 +0200)
commit85c1186f5df971d6d30affb7c064a7841ccdbd3a
treee99bf1a8ff7de40745e6959d9ee1c5dc958d5ef7
parenta700bd8decb8626f3f4652d793674fc3ac8ef21b
tcp: reset sk_rx_dst in tcp_disconnect()

[ Upstream commit d747a7a51b00984127a88113cdbbc26f91e9d815 ]

We have to reset the sk->sk_rx_dst when we disconnect a TCP
connection, because otherwise when we re-connect it this
dst reference is simply overridden in tcp_finish_connect().

This fixes a dst leak which leads to a loopback dev refcnt
leak. It is a long-standing bug, Kevin reported a very similar
(if not same) bug before. Thanks to Andrei for providing such
a reliable reproducer which greatly narrows down the problem.

Fixes: 41063e9dd119 ("ipv4: Early TCP socket demux.")
Reported-by: Andrei Vagin <avagin@gmail.com>
Reported-by: Kevin Xu <kaiwen.xu@hulu.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/tcp.c