]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
PCI: endpoint: Fix configfs group removal on driver teardown
authorDamien Le Moal <dlemoal@kernel.org>
Tue, 24 Jun 2025 11:45:44 +0000 (20:45 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:26:07 +0000 (16:26 +0200)
commit85ea58de57220fd321cf6446bc485c8be65ef6f2
treec39e9f8c68ab051bdafe00d603d0f07159857878
parent409af8b9f7b4f23cd0464e71c6cd6fe13c076ae2
PCI: endpoint: Fix configfs group removal on driver teardown

commit 910bdb8197f9322790c738bb32feaa11dba26909 upstream.

An endpoint driver configfs attributes group is added to the
epf_group list of struct pci_epf_driver by pci_epf_add_cfs() but an
added group is not removed from this list when the attribute group is
unregistered with pci_ep_cfs_remove_epf_group().

Add the missing list_del() call in pci_ep_cfs_remove_epf_group()
to correctly remove the attribute group from the driver list.

With this change, once the loop over all attribute groups in
pci_epf_remove_cfs() completes, the driver epf_group list should be
empty. Add a WARN_ON() to make sure of that.

Fixes: ef1433f717a2 ("PCI: endpoint: Create configfs entry for each pci_epf_device_id table entry")
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20250624114544.342159-3-dlemoal@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pci/endpoint/pci-ep-cfs.c
drivers/pci/endpoint/pci-epf-core.c