]> git.ipfire.org Git - thirdparty/linux.git/commit
net: hsr: reject unresolved interlink ifindex
authorLuka Gejak <luka.gejak@linux.dev>
Wed, 13 May 2026 18:26:57 +0000 (20:26 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 16 May 2026 00:31:00 +0000 (17:31 -0700)
commit85ee970039f8f2a8911bf7efcd228cbc471fd38e
tree4ef0ddcd3873ee95244e3b3ff51753601179783c
parentbbfb1983944f2eaa8ee192e0f7b59ecc0fda9981
net: hsr: reject unresolved interlink ifindex

In hsr_newlink(), a provided but invalid IFLA_HSR_INTERLINK attribute
was silently ignored if __dev_get_by_index() returned NULL. This leads
to incorrect RedBox topology creation without notifying the user.

Fix this by returning -EINVAL and an extack message when the
interlink attribute is present but cannot be resolved.

Reviewed-by: Felix Maurer <fmaurer@redhat.com>
Signed-off-by: Luka Gejak <luka.gejak@linux.dev>
Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
Link: https://patch.msgid.link/20260513182657.20346-3-luka.gejak@linux.dev
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/hsr/hsr_netlink.c