]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
crypto: arm,arm64 - Fix random regeneration of S_shipped
authorLeonard Crestez <leonard.crestez@nxp.com>
Tue, 13 Mar 2018 20:17:23 +0000 (22:17 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 8 Apr 2018 12:27:39 +0000 (14:27 +0200)
commit860783c283c85530a9ff02bb83b461cc2da1e806
tree631868d1918a8db80553469c70d2ad2741110cd2
parent493601f76734e2478e774ce8e6df5c8768ddaced
crypto: arm,arm64 - Fix random regeneration of S_shipped

commit 6aaf49b495b446ff6eec0ac983f781ca0dc56a73 upstream.

The decision to rebuild .S_shipped is made based on the relative
timestamps of .S_shipped and .pl files but git makes this essentially
random. This means that the perl script might run anyway (usually at
most once per checkout), defeating the whole purpose of _shipped.

Fix by skipping the rule unless explicit make variables are provided:
REGENERATE_ARM_CRYPTO or REGENERATE_ARM64_CRYPTO.

This can produce nasty occasional build failures downstream, for example
for toolchains with broken perl. The solution is minimally intrusive to
make it easier to push into stable.

Another report on a similar issue here: https://lkml.org/lkml/2018/3/8/1379

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Cc: <stable@vger.kernel.org>
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm/crypto/Makefile
arch/arm64/crypto/Makefile