]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
i2c: muxes: i2c-mux-pinctrl: Use of_get_i2c_adapter_by_node()
authorHerve Codina <herve.codina@bootlin.com>
Fri, 20 Oct 2023 15:30:11 +0000 (17:30 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Nov 2023 10:21:06 +0000 (11:21 +0100)
commit8682ab6f7ce1a6962f73d572e395d6679cd6a55d
treeda110fb7e942d56dd0bf96586fe0471919eed5a5
parent587f2a2273b9a437482d0b76c0138017bad196cc
i2c: muxes: i2c-mux-pinctrl: Use of_get_i2c_adapter_by_node()

commit 3171d37b58a76e1febbf3f4af2d06234a98cf88b upstream.

i2c-mux-pinctrl uses the pair of_find_i2c_adapter_by_node() /
i2c_put_adapter(). These pair alone is not correct to properly lock the
I2C parent adapter.

Indeed, i2c_put_adapter() decrements the module refcount while
of_find_i2c_adapter_by_node() does not increment it. This leads to an
underflow of the parent module refcount.

Use the dedicated function, of_get_i2c_adapter_by_node(), to handle
correctly the module refcount.

Fixes: c4aee3e1b0de ("i2c: mux: pinctrl: remove platform_data")
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Cc: stable@vger.kernel.org
Acked-by: Peter Rosin <peda@axentia.se>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/i2c/muxes/i2c-mux-pinctrl.c